Fix trailing hyphen in resource_filename when nFix trailing hyphen in resource_filename when slugified name ends with extensioname ends with slugifie…#228
Open
samuel-frankliln wants to merge 1 commit intockan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d extension## Problem
A resource titled "S_ptarmigan_counts_readme.pdf" produces the path
"data/s-ptarmigan-counts-readme-.pdf" instead of
"data/s-ptarmigan-counts-readme.pdf".
Root Cause
In resource_filename(), after stripping the slugified extension from
the name, a trailing hyphen is left behind before the extension is
re-appended.
Fix
Added name.rstrip('-.') after stripping the extension to remove any
trailing hyphens or dots.
Testing
Added a test case to TestResourceFilename reproducing the exact
scenario described above.